Re: [PATCH] submodule--helper: normalize funny urls

From: Stefan Beller <sbeller@google.com>
Date: Oct 18, 2016, 17:17 UTC
Message-ID: <CAGZ79kZEFanPpdrE4sD64LJHmyrBiHafo1VzoGtoGh+wO_HCuw@mail.gmail.com>
In-Reply-To: <xmqqr37dpoip.fsf@gitster.mtv.corp.google.com>

On Tue, Oct 18, 2016 at 10:15 AM, Junio C Hamano <gitster@pobox.com> wrote:

>
> I also somehow find the "check-url-stripping" variable ugly.
>
>         while (URL still has something that could be stripped) {

for(;;) {

here ? (this code would not need a variable, and for wins over while: $ git grep "while (1)" |wc -l 107 $ git grep "for (;;)" |wc -l 128 )

Show 12 quoted lines

>                 if (ends with "/.") {
>                         strip "/.";
>                         continue;
>                 }
>                 if (ends with "/") {
>                         strip "/";
>                         continue;
>                 }
>                 break;
>         }
>
> perhaps?