Re: [PATCH] Add --indent-heuristic to bash completion.

From: Stefan Beller <sbeller@google.com>
Date: Apr 27, 2017, 16:37 UTC
Message-ID: <CAGZ79kZ7eHO+Uv1xk1UXpO39uqCEGkpnxOCMARqJP9hAtqC1gg@mail.gmail.com>
In-Reply-To: <71692231-0a76-99f7-3577-9076b0f2e8ad@suse.cz>

On Thu, Apr 27, 2017 at 2:09 AM, Martin Liška <mliska@suse.cz> wrote:

Show 13 quoted lines

> On 04/26/2017 09:38 PM, Stefan Beller wrote:
>> On Tue, Apr 25, 2017 at 4:37 AM, Martin Liška <mliska@suse.cz> wrote:
>>> Hello.
>>>
>>> The patch adds BASH completion for a newly added option.
>>>
>>
>> The looks good, though the format is unusual. (We prefer the
>> format to be inline instead of an attachment)
>
> Good, adding inline version.
> I've read Documentation/SubmittingPatches, can you please help me which
> maintainer should I CC?

cc'd Junio (the only maintainer in Git, are you a kernel developer, where you have hundreds of maintainers?)

Thanks, Stefan

Show 37 quoted lines

>
> Martin
> ---
>  contrib/completion/git-completion.bash | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 1150164d5..8fb25594c 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1395,7 +1395,7 @@ __git_diff_common_options="--stat --numstat --shortstat --summary
>                         --quiet --ext-diff --no-ext-diff
>                         --no-prefix --src-prefix= --dst-prefix=
>                         --inter-hunk-context=
> -                       --patience --histogram --minimal
> +                       --patience --histogram --indent-heuristic --minimal
>                         --raw --word-diff --word-diff-regex=
>                         --dirstat --dirstat= --dirstat-by-file
>                         --dirstat-by-file= --cumulative
> @@ -1482,6 +1482,7 @@ __git_format_patch_options="
>         --not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=
>         --inline --suffix= --ignore-if-in-upstream --subject-prefix=
>         --output-directory --reroll-count --to= --quiet --notes
> +       --indent-heuristic
>  "
>
>  _git_format_patch ()
> @@ -1681,6 +1682,7 @@ __git_log_common_options="
>         --min-age= --until= --before=
>         --min-parents= --max-parents=
>         --no-min-parents --no-max-parents
> +       --indent-heuristic
>  "
>  # Options that go well for log and gitk (not shortlog)
>  __git_log_gitk_options="
> --
> 2.12.2