git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1200: remove t1200-tutorial.sh

From
Stefan Beller <sbeller@google.com>
Date
Aug 9, 2017, 00:13 UTC
Message-ID
<CAGZ79kZ45=2ngM437fdj8KCJjJo5h0R7FtmEBBG+VVkm0pTLrw@mail.gmail.com>
In-Reply-To
<20170809000742.GG169894@aiede.mtv.corp.google.com>
On Tue, Aug 8, 2017 at 5:07 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 34 quoted lines
> Hi,
>
> Stefan Beller wrote:
>
>> Nowadays there are better tutorials out there such as "Git from bottom up"
>> or others, easily found online. Additionally to that a tutorial in our
>> test suite is not as easy to discover as e.g. online tutorials.
>>
>> This test/tutorial was discovered by the patch author in the effort to
>> migrate our tests in preparation to switch the hashing function.
>> Transforming this tutorial to be agnostic of the underlying hash function
>> would hurt its readability, hence being even less useful as a tutorial.
>>
>> Instead delete this test as
>> (a) the functionality is tested elsewhere as well and
>> (b) reducing the test suite to its core improves performance, which
>>     aids developers in keeping their development velocity.
>>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>  t/t1200-tutorial.sh | 268 ----------------------------------------------------
>>  1 file changed, 268 deletions(-)
>>  delete mode 100755 t/t1200-tutorial.sh
>
> Interesting.  When I first saw the diffstat I assumed you were talking
> about a test that validates the examples in some manpage are correct.
> But this is not that.
>
> There indeed appear to be other good tests for these commands, even
> "git whatchanged", so for what it's worth,
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks.

2ae6c70674 (Adapt tutorial to cygwin and add test case, 2005-10-13) seemed to imply that it was testing some part for Documentation/tutorial.txt though.

Previous: Jonathan NiederNext: Jonathan Nieder
Message 3 of 9 in “t1200: remove t1200-tutorial.sh”
  1. t1200: remove t1200-tutorial.shStefan Beller, Aug 8, 2017
  2. Jonathan NiederAug 9, 2017
  3. Stefan BellerAug 9, 2017
  4. Jonathan NiederAug 9, 2017
  5. Jonathan NiederAug 9, 2017
  6. Junio C HamanoAug 9, 2017
  7. t1200: remove t1200-tutorial.shStefan Beller, Aug 9, 2017
  8. Johannes SchindelinAug 9, 2017
  9. Junio C HamanoAug 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.