Re: [PATCH 2/9] sha1-array: provide oid_array_filter

From: Stefan Beller <sbeller@google.com>
Date: Sep 17, 2018, 21:42 UTC
Message-ID: <CAGZ79kYtR4BgzFDfHookB-ax1wN0TVH1Qam3vC99ypjwr=PHgQ@mail.gmail.com>
In-Reply-To: <20180917213559.126404-3-sbeller@google.com>

On Mon, Sep 17, 2018 at 2:36 PM Stefan Beller <sbeller@google.com> wrote:

Show 23 quoted lines

>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  sha1-array.c | 17 +++++++++++++++++
>  sha1-array.h |  9 +++++++++
>  2 files changed, 26 insertions(+)
>
> diff --git a/sha1-array.c b/sha1-array.c
> index 265941fbf40..67db5eeec9a 100644
> --- a/sha1-array.c
> +++ b/sha1-array.c
> @@ -77,3 +77,20 @@ int oid_array_for_each_unique(struct oid_array *array,
>         }
>         return 0;
>  }
> +
> +void oid_array_filter(struct oid_array *array,
> +                     for_each_oid_fn want,
> +                     void *cb_data)
> +{
> +       unsigned nr = array->nr, src, dst;
> +       struct object_id *oids = array->oids;

Blargh :-(

I made this last minute "pull oids out to be more like the object_array_filter" and typo'd without compile checking.

Please discard this series.

Stefan