Re: [PATCH 2/2] pkt-line: show packets in async processes as "sideband"

From: Stefan Beller <sbeller@google.com>
Date: Sep 1, 2015, 22:31 UTC
Message-ID: <CAGZ79kYoWWc34GOxyAi5WvYf=UQvt--qwEr_m+bZwKO-uVqkiw@mail.gmail.com>
In-Reply-To: <20150901222639.GD7862@sigill.intra.peff.net>

On Tue, Sep 1, 2015 at 3:26 PM, Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

> On Tue, Sep 01, 2015 at 03:23:06PM -0700, Stefan Beller wrote:
>
>> > Hmm, does Stefan's thread-pool thing interact with this decision in
>> > any way?
>>
>> I do not plan to actually fetch from inside the thread pool, but each thread
>> is just a proxy for starting a new process doing the fetch and getting
>> the output
>> in order.
>
> Ah, right, I think I misunderstood Junio's question. Yes, if we start
> calling cmd_fetch() from inside the threads, things may get confusing.
>
> I'll see how painful the thread storage approach would be.

I think that may be part of the thread pool API eventually.

I don't plan on relying on thread local storage, which is why I did not add it there, though I guess it can be added in there quite conveniently.

>
> -Peff