Re: [PATCH 0/2] doc hash-function-transition: minor & major clarifications

From

Stefan Beller <sbeller@google.com>

Date

Mar 26, 2018, 18:35 UTC

Message-ID

<CAGZ79kYcX6z6276c1R8k0qya56G5UzuM96mOxhAOtG7OFw=TqA@mail.gmail.com>

In-Reply-To

<20180326182708.26551-1-avarab@gmail.com>

> Having read through the hash-function-transition.txt again, a couple
> of things jumped out at me:

> Ævar Arnfjörð Bjarmason (2):
>    doc hash-function-transition: clarify how older gits die on NewHash

> We weren't accurately describing how "git status" would die on NewHash
> repos on new versions.

>    doc hash-function-transition: clarify what SHAttered means

> I don't think we had a good summary of how SHA-1 vulnerabilities
> overlap with concerns Git has, now that we've moved to the hardened
> SHA-1.

> I may very well have gotten this new summary subtly wrong though. So
> please review.

>   .../technical/hash-function-transition.txt    | 40 +++++++++++++++----
>   1 file changed, 32 insertions(+), 8 deletions(-)

Both patches look good to me.

Stefan