git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: do no re-read name in shell script

From
Stefan Beller <sbeller@google.com>
Date
Jul 21, 2016, 01:40 UTC
Message-ID
<CAGZ79kYZphh7f6tf0a7=6gKf+=Vg1zO5MdCNypZ0vC8d3Fh7=A@mail.gmail.com>
In-Reply-To
<20160721010029.GG29326@google.com>
On Wed, Jul 20, 2016 at 6:00 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 5 quoted lines
>> -                     needs_cloning, ce->name);
>> +                     needs_cloning, sub->name, sub->path);
>
> Are there any restrictions on what characters a submodule name can
> contain?  Does this need e.g. to be quoted with sq_quote?

Oh good point, this ought to fail with weird names. So instead of quoting it, let's just drop this patch.

>
> Thanks,
> Jonathan
Previous: Jonathan Nieder
Message 3 of 3 in “submodule: do no re-read name in shell script”
  1. submodule: do no re-read name in shell scriptStefan Beller, Jul 21, 2016
  2. Jonathan NiederJul 21, 2016
  3. Stefan BellerJul 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.