Re: [PATCH] git-gui: Do not reset author details on amend

From: Stefan Beller <sbeller@google.com>
Date: Sep 27, 2016, 17:45 UTC
Message-ID: <CAGZ79kYYUNf7AvpQu=NzrujM6pCdBK_JunZhC-CxPkfRcNDL6g@mail.gmail.com>
In-Reply-To: <CAGHpTB+XOxMh=o_dKGx-j2P15zsmcMn0MB7BuKFksOn4O_FXYw@mail.gmail.com>

On Tue, Sep 27, 2016 at 10:23 AM, Orgad Shaneh <orgads@gmail.com> wrote:

Show 14 quoted lines

> On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Orgad Shaneh <orgads@gmail.com> writes:
>>
>>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> Orgad Shaneh <orgads@gmail.com> writes:
>>>>
>>> I actually see that there is a problem with it:
>>> https://github.com/git-for-windows/git/issues/761
>>>
>>> I'll try to revise it and resubmit.
>>
>> Are you by chance volunteering to be git-gui maintainer?
>
> No way, sorry. I don't speak TCL at all. Every change is a true pain... ;)

I considered stepping up as an interim maintainer briefly, but this is the exact reason on why I punted.

Looking at e.g. `git diff --stat gitgui-0.19.0..gitgui-0.20.0` (which is 16 month apart), the workload seems to be very light, so I would not have concerns w.r.t. time spent.

Stepping back a bit and asking "What does a maintainer do?" I think knowing the language very well is not the top point, but rather looking at the design, maintainability of proposed solutions as well as long term well being of the project is what makes a good maintainer.

That said I could step up as a maintainer, but for each patch I"d ask the contributor to find a reviewer who knows tcl well, as that is a part that I cannot cover. And from a contributors perspective this seems to be discouraging.

Stefan

>
> - Orgad