git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 1/4] submodule.h: add extern keyword to functions

From
Stefan Beller <sbeller@google.com>
Date
Dec 27, 2016, 17:59 UTC
Message-ID
<CAGZ79kYU3yKrMwQp96-wdHedwzX7tKE1NK2OwdfOau1U3q1gaA@mail.gmail.com>
In-Reply-To
<xmqqinq6cgxa.fsf@gitster.mtv.corp.google.com>
On Mon, Dec 26, 2016 at 5:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> As the upcoming series will add a lot of functions to the submodule
>> header, let's first make the header consistent to the rest of the project
>> by adding the extern keyword to functions.
>
> This may be the right thing to do in the longer term but a patch
> like this adds a lot of unnecessary work on the integrator when
> there are _other_ topics that are in flight.  I'll see how bad the
> conflicts are while merging the topic to 'pu'.
>
> Thanks.

Maybe we can roll this patch on its own, so in case the latter patches need rerolls we still have this one and can build on top?

Thanks, Stefan

Previous: Junio C HamanoNext: Stefan Beller
Message 4 of 13 in “[PATCHv5 0/4] git-rm absorbs submodule git directory before deletion”
  1. Stefan BellerDec 20, 2016
  2. 1/4 submodule.h: add extern keyword to functionsStefan Beller, Dec 20, 2016
  3. Junio C HamanoDec 27, 2016
  4. Stefan BellerDec 27, 2016
  5. 2/4 submodule: modernize ok_to_remove_submodule to use argv_arrayStefan Beller, Dec 20, 2016
  6. 3/4 submodule: rename and add flags to ok_to_remove_submoduleStefan Beller, Dec 20, 2016
  7. Junio C HamanoDec 27, 2016
  8. Stefan BellerDec 27, 2016
  9. 4/4 rm: absorb a submodules git dir before deletionStefan Beller, Dec 20, 2016
  10. Junio C HamanoDec 27, 2016
  11. Stefan BellerDec 27, 2016
  12. Stefan BellerDec 27, 2016
  13. Junio C HamanoDec 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.