Re: [PATCH v3 5/6] trailer: allow non-trailers in trailer block

From: Stefan Beller <sbeller@google.com>
Date: Oct 18, 2016, 00:49 UTC
Message-ID: <CAGZ79kYLq1qA4_Qg2x5Fiu5AmGBZdozm4zk6K7LkU+uJ1LNUTw@mail.gmail.com>
In-Reply-To: <1b3fe84e4b6126884a801e721d0a93c41fcb4184.1476466609.git.jonathantanmy@google.com>

On Fri, Oct 14, 2016 at 10:38 AM, Jonathan Tan <jonathantanmy@google.com> wrote:

Show 5 quoted lines

>
>  Existing trailers are extracted from the input message by looking for
> -a group of one or more lines that contain a colon (by default), where
> +a group of one or more lines in which at least one line contains a
> +colon (by default), where

Please see commit 578e6021c0819d7be1179e05e7ce0e6fdb2a01b7 for an example where I think this is overly broad.

Another made up example, that I'd want to feed in commit -s eventually:

--8<-- demonstrate colons in Java

First paragraph is not interesting.

Also if using another Language such as Java, where I point out Class::function() to be problematic --8<--

This would lack the white space between the last paragraph and the Sign off ?

So for this patch I am mostly concerned about false positives hidden in actual text.