Re: [PATCH 20/20] packed-backend.c: rename a bunch of things and update comments
- From
Stefan Beller <sbeller@google.com>
- Date
- Sep 13, 2017, 23:00 UTC
- Message-ID
- <CAGZ79kYHzWaPXGE29RUe1J+T_=AHKADhv2TjkMSUu5NM80zX1w@mail.gmail.com>
- In-Reply-To
- <8844c66d7b245dda7a2fa2794cb4051b5b2b35e2.1505319366.git.mhagger@alum.mit.edu>
On Wed, Sep 13, 2017 at 10:16 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
Show 21 quoted lines
> We've made huge changes to this file, and some of the old names and > comments are no longer very fitting. So rename a bunch of things: > > * `struct packed_ref_cache` → `struct snapshot` > * `acquire_packed_ref_cache()` → `acquire_snapshot()` > * `release_packed_ref_buffer()` → `clear_snapshot_buffer()` > * `release_packed_ref_cache()` → `release_snapshot()` > * `clear_packed_ref_cache()` → `clear_snapshot()` > * `struct packed_ref_entry` → `struct snapshot_record` > * `cmp_packed_ref_entries()` → `cmp_packed_ref_records()` > * `cmp_entry_to_refname()` → `cmp_record_to_refname()` > * `sort_packed_refs()` → `sort_snapshot()` > * `read_packed_refs()` → `create_snapshot()` > * `validate_packed_ref_cache()` → `validate_snapshot()` > * `get_packed_ref_cache()` → `get_snapshot()` > * Renamed local variables and struct members accordingly. > > Also update a bunch of comments to reflect the renaming and the > accumulated changes that the code has undergone. > > Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
I have skimmed this series and it looks good. Thanks, Stefan