Re: [PATCHv3] attr: convert to new threadsafe API
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 13, 2016, 18:42 UTC
- Message-ID
- <CAGZ79kYEefzKJT5TLXaGV0ZYoW=OUzrRBPTOovDG0ofO8-i5Jg@mail.gmail.com>
- In-Reply-To
- <xmqqfuo116t0.fsf@gitster.mtv.corp.google.com>
On Wed, Oct 12, 2016 at 4:33 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Stefan Beller <sbeller@google.com> writes: > >> @@ -89,15 +114,20 @@ static void setup_check(void) >> >> ------------ >> const char *path; >> + struct git_attr_result *result; >> >> setup_check(); >> - git_check_attr(path, check); >> + result = git_check_attr(path, check); > > This looks stale by a few revisions of the other parts of the patch?
I'll update the documentation.
Show 43 quoted lines
>
>> diff --git a/archive.c b/archive.c
>> index 11e3951..15849a8 100644
>> --- a/archive.c
>> +++ b/archive.c
>> @@ -107,10 +107,12 @@ static int write_archive_entry(const unsigned char *sha1, const char *base,
>> void *context)
>> {
>> static struct strbuf path = STRBUF_INIT;
>> + static struct git_attr_check *check;
>> +
>> struct archiver_context *c = context;
>> struct archiver_args *args = c->args;
>> write_archive_entry_fn_t write_entry = c->write_entry;
>> - static struct git_attr_check *check;
>> + struct git_attr_result result = GIT_ATTR_RESULT_INIT;
>> const char *path_without_prefix;
>> int err;
>>
>> @@ -124,12 +126,16 @@ static int write_archive_entry(const unsigned char *sha1, const char *base,
>> strbuf_addch(&path, '/');
>> path_without_prefix = path.buf + args->baselen;
>>
>> - if (!check)
>> - check = git_attr_check_initl("export-ignore", "export-subst", NULL);
>> - if (!git_check_attr(path_without_prefix, check)) {
>> - if (ATTR_TRUE(check->check[0].value))
>> + git_attr_check_initl(&check, "export-ignore", "export-subst", NULL);
>> + git_attr_result_init(&result, check);
>> +
>> + if (!git_check_attr(path_without_prefix, check, &result)) {
>> + if (ATTR_TRUE(result.value[0])) {
>> + git_attr_result_clear(&result);
>> return 0;
>> - args->convert = ATTR_TRUE(check->check[1].value);
>> + }
>> + args->convert = ATTR_TRUE(result.value[1]);
>> + git_attr_result_clear(&result);
>> }
>
> This is exactly what I meant by "can we avoid alloc/free of result
> in leaf function when we _know_ how many attributes we are
> interested in already, which is the majority of the case?".We can avoid that. For now I settled with an implementation that has no "answer" type, but uses a bare "const char *result[FLEX_ARRAY];", or rather a const char **.
Show 8 quoted lines
> > Starting with a simple but unoptimized internal implementation of > the attr subsystem is one thing (which is good). Exposing an API that > cannot be optimally implemented later without changing the callers > is another (which is bad). > > By encapsulating each element into "struct git_attr_result", we can > extend the API without changing the API user [*1*].
Oh I see.
So instead of a raw string we want to have
struct git_attr_result {
const char *value;
};just to have it extensible. Makes sense. I'll redo that.
Show 6 quoted lines
> > But I do not think of a way to allow an efficient implementation > later unless the source of the API user somehow says "this user is > only interested in this many attributes", like having this > > struct git_attr_result result[2];
const char *result[2] = {NULL, NULL};as of now would be
struct git_attr_result result[2];
but we'd lose the ability to set them to NULL easily. Probably not needed.
Show 14 quoted lines
> > (because this caller only wants "ignore" and "subst") on the API > user's side [*2*]. Without such a clue (like the patch above, that > only says "there is a structure called 'result'"), I do not think of > a way to avoid dynamic allocation on the API implementation side. > > All the other callers in the patch (pack-objects, convert, ll-merge, > etc.) seem to share the exact same pattern. Each of the leaf > functions knows a fixed set of attributes it is interested in, the > caller iterates over many paths and makes calls to these leaf > functions, and it is a waste to pay alloc/free overhead for each and > every iteration when we know how many elements result needs to > store. >
Right.
Show 49 quoted lines
>
> [Footnote]
>
> *1* Would we need a wrapping struct around the array of results? If
> that is the case, we may need something ugly like this on the
> API user side:
>
> GIT_ATTR_RESULT_TYPE(2) result = {2,};
>
> with something like the following on the API implementation
> side:
>
> #define GIT_ATTR_RESULT_TYPE(n) \
> struct { \
> int num_slots; \
> const char *value[n]; \
> }
>
> struct git_attr_result {
> int num_slots;
> const char *value[FLEX_ARRAY];
> };
> git_attr_result_init(void *result_, struct git_attr_check *check)
> {
> struct git_attr_result *result = result_;
>
> assert(result->num_slots, check->num_attrs);
> ...
> }
> git_check_attr(const char *path,
> struct git_attr_check *check,
> void *result_)
> {
> struct git_attr_result *result = result_;
>
> assert(result->num_slots, check->num_attrs);
> for (i = 0; i < check_num_attrs; i++)
> result->value[i] = ... found value ...;
> }
>
>
> *2* Or the uglier
>
> GIT_ATTR_RESULT_TYPE(2) result = {2,};
>
> I can see why the "check" side would benefit from a structure
> that contains an array, but I do not see why "result" side would
> want to, so I am hoping that we won't have to do this uglier
> variant and just go with the simple "array of resulting values".So I currently have the "array of resulting values", but not wrapped.
Do we expect to get more than the values out of the attr system?