Re: [PATCH 5/5] test-run-command: Increase test coverage
On Tue, Oct 20, 2015 at 11:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
>
> proc.argv = (const char **)argv + 3;
>
> or
>
> proc.argv = (const char **)&argv[3];
Show 6 quoted lines
>
> Given the line immediately before refers to argv[2], the latter
> might be easier on the eyes to follow.
>
> In what way does this "Increase" test coverage? By allowing the
> caller to specify arbitrarily higher parallelism?
Currently we have exact 4 jobs to be run with at most 4 parallel
processes. This sounds as if we're testing only one special case,
but in reality we want to have any number of tasks be processed
successfully, so the test I came up with is 3 cases
* more tasks than max jobs (implying reused slots)
* equal number of jobs and max jobs
* less tasks than max jobs (implying unused slots)
Show 13 quoted lines
>
>> +
>> + if (!strcmp(argv[1], "run-command-parallel"))
>> + exit(run_processes_parallel(jobs, parallel_next,
>> NULL, NULL, &proc));
>>
>> - if (!strcmp(argv[1], "run-command-abort-3"))
>> - exit(run_processes_parallel(3, parallel_next,
>> + if (!strcmp(argv[1], "run-command-abort"))
>> + exit(run_processes_parallel(jobs, parallel_next,
>> NULL, task_finished, &proc));
>>
>> fprintf(stderr, "check usage\n");
Stefan Beller <sbeller@google.com>