Re: [PATCH 7/7] submodule--helper: introduce new update-module-mode helper

From: Stefan Beller <sbeller@google.com>
Date: Aug 20, 2018, 19:44 UTC
Message-ID: <CAGZ79kYALb4=uth1mMFdYLQCz=Z0m0VJDaGe5zWmXbYNDFui-Q@mail.gmail.com>
In-Reply-To: <CACsJy8BWTd5LEtZ00z7a1sOwx3n=RfPDqguNb+zTW0CZUUyJaA@mail.gmail.com>

On Sat, Aug 18, 2018 at 9:11 AM Duy Nguyen <pclouds@gmail.com> wrote:

Show 12 quoted lines

>
> On Tue, Aug 14, 2018 at 12:45 AM Stefan Beller <sbeller@google.com> wrote:
> > +static int module_update_module_mode(int argc, const char **argv, const char *prefix)
> > +{
> > +       const char *path, *update = NULL;
> > +       int just_cloned;
> > +       struct submodule_update_strategy update_strategy = { .type = SM_UPDATE_CHECKOUT };
> > +
> > +       if (argc < 3 || argc > 4)
> > +               die("submodule--helper update-module-clone expects <just-cloned> <path> [<update>]");
>
> Maybe _() ?

I would rather not, as the submodule--helper is "internal only" and these die() calls could be clarified via

    #define BUG_IN_CALLING_SH(x) die(x)

After the conversion to C is done, all these submodule helpers would go away, so I'd not burden the translators too much?

Thanks, Stefan