Re: [PATCH v2 3/4] grep: fix bug when recursing with relative pathspec

From: Stefan Beller <sbeller@google.com>
Date: Mar 14, 2017, 23:03 UTC
Message-ID: <CAGZ79kY0d45SB8JHWO6jo+WTQQLsZ2jMSVEeeKPjWG7FkJTryA@mail.gmail.com>
In-Reply-To: <20170314221100.24856-4-bmwill@google.com>

On Tue, Mar 14, 2017 at 3:10 PM, Brandon Williams <bmwill@google.com> wrote:

Show 6 quoted lines

> This patch fixes the bug by passing the 'prefix' to the child process.
> Now each child process that works on a submodule has two points of
> reference to the superproject: (1) the 'super_prefix' which is the path
> from the root of the superproject down to root of the submodule and (2)
> the 'prefix' which is the path from the root of the superproject down to
> the directory where the user invoked the git command.

Would the information of this paragraph also be well suited in the documentation?

(1) clarifies what the super prefix is.
(2) maybe the docs or this commit message should talk about
  how the prefix is relayed, i.e. it doesn't set 'prefix' in the child,
  but it reads GIT_TOPLEVEL_PREFIX_ENVIRONMENT and
  acts on that as (2) ?