git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-prompt: show presence of unresolved conflicts at command prompt

From
Justin Donnelly <justinrdonnelly@gmail.com>
Date
Aug 16, 2022, 03:36 UTC
Message-ID
<CAGTqyRyBAR1SCpKwU2mTTKz0-nOPgJ1Es6aGVBgJqrnZ9Z_P1w@mail.gmail.com>
In-Reply-To
<r980s5q6-7714-8r0q-4sp1-3qs1458r17qs@tzk.qr>

On Mon, Aug 15, 2022 at 8:50 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 24 quoted lines
>
> Hi,
>
> On Sun, 14 Aug 2022, Junio C Hamano wrote:
>
> > Justin Donnelly <justinrdonnelly@gmail.com> writes:
> >
> > > I hope this is against protocol/etiquette, but after some initial
> > > feedback from Junio, I haven't gotten any more. I wasn't sure if
> > > nobody had seen the patch, or if there just wasn't any interest.
> >
> > It probably is a bit of both.  I personally did not see much point
> > in adding the long "conflicts" marker to the shell prompt (I did
> > worry about possible complaints by end users triggered by seeing
> > them suddenly without asking, which was why I commented on the
> > patch) and I was waiting for interested folks to speak out.
>
> Speaking for myself, I was too busy elsewhere. But now that I looked over
> the patch, I think it is fine. My only feedback is that it would be wise
> to only add a single test case because that is plenty enough (after all,
> it validates the `ls-files --unmerged` call and not the `cherry-pick`
> code) and it is unnecessary to waste the electricity on additional tests
> cases (even if somebody else foots the bill, it would do well for all of
> us to start being more mindful about energy consumption).

That makes sense. I'll get started on a re-roll to just have a single test that focuses specifically on the conflict indicator.

>
> Ciao,
> Dscho

Thanks, Justin

Previous: Johannes SchindelinNext: Phillip Wood
Message 10 of 17 in “git-prompt: show 'CONFLICT' indicator at command prompt”
  1. git-prompt: show 'CONFLICT' indicator at command promptJustin Donnelly via GitGitGadget, Jul 26, 2022
  2. Junio C HamanoJul 27, 2022
  3. Justin DonnellyJul 28, 2022
  4. Junio C HamanoJul 28, 2022
  5. Justin DonnellyJul 28, 2022
  6. git-prompt: show presence of unresolved conflicts at command promptJustin Donnelly via GitGitGadget, Jul 29, 2022
  7. Justin DonnellyAug 14, 2022
  8. Junio C HamanoAug 15, 2022
  9. Johannes SchindelinAug 15, 2022
  10. Justin DonnellyAug 16, 2022
  11. Phillip WoodAug 15, 2022
  12. Junio C HamanoAug 15, 2022
  13. Justin DonnellyAug 16, 2022
  14. Justin DonnellyAug 16, 2022
  15. git-prompt: show presence of unresolved conflicts at command promptJustin Donnelly via GitGitGadget, Aug 17, 2022
  16. Johannes SchindelinAug 19, 2022
  17. Junio C HamanoAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.