Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

From: Kicer Jiao <joykicer@gmail.com>
Date: Mar 17, 2014, 09:34 UTC
Message-ID: <CAGRPCXyf_QtHm3g2DY9Q3+9qrHegbE+nXoR=YAw_YcQvS+kCRg@mail.gmail.com>
In-Reply-To: <CAGRPCXzJXfKtB1wkOMN_7dQ6RdXAs5YNQ+p70eoUYOr5zXkM_w@mail.gmail.com>

Dear all,

I have a git-project which source code use gbk encoding. When use gitweb blame view, it will report an error then stop parse:

>    Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line 1595, &lt;$fd&gt; line 45.

After apply this patch, blame view of gbk source file will back to normally.

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 79057b7..e6fdcfe 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -6704,7 +6704,6 @@ sub git_blame_common {
                        $hash_base, '--', $file_name
                        or die_error(500, "Open git-blame --porcelain failed");
        }
-       binmode $fd, ':utf8';

        # incremental blame data returns early
        if ($format eq 'data') {

When I search the git.git log, this commit add the "binmode ..." line,
maybe should recheck this commit? Thanks.
fd87004e51df835e5833bfe1bff3ad0137d42227  "gitweb: Fix the author
initials in blame for non-ASCII names"


BR,
2014-03-17