git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] submodule: suppress checking for file name ambiguity for object ids

From
Orgad Shaneh <orgads@gmail.com>
Date
Sep 6, 2020, 19:25 UTC
Message-ID
<CAGHpTBKduYnWymtCYR0AAdYy4rhXZgQkrUiHu59bpNX5UDEYfg@mail.gmail.com>
In-Reply-To
<pull.725.v2.git.1599370473141.gitgitgadget@gmail.com>

On Sun, Sep 6, 2020 at 8:34 AM Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 11 quoted lines
>
> From: Orgad Shaneh <orgads@gmail.com>
>
> The argv argument of collect_changed_submodules() contains obly object ids
> (the objects references of all the refs).
>
> Notify setup_revisions() that the input is not filenames by passing
> assume_dashdash, so it can avoid redundant stat for each ref.
>
> A better improvement would be to pass oid_array instead of stringified argv,
> but that will require a larger change, which can be done later.

I'm wondering if it would be possible to track all the commits that were received via the transport, instead of resolving them by ref changes, because resolving from refs requires excluding all the previously-known refs, which can be a lot. Our repository has ~35K tags, and I believe there are larger repos out there...

What do you say?
- Orgad
Previous: Orgad Shaneh via GitGitGadgetNext: Orgad Shaneh via GitGitGadget
Message 3 of 7 in “submodule: suppress checking for file name ambiguity for object ids”
  1. submodule: suppress checking for file name ambiguity for object idsOrgad Shaneh via GitGitGadget, Sep 4, 2020
  2. submodule: suppress checking for file name ambiguity for object idsOrgad Shaneh via GitGitGadget, Sep 6, 2020
  3. Orgad ShanehSep 6, 2020
  4. submodule: suppress checking for file name and ref ambiguity for object idsOrgad Shaneh via GitGitGadget, Sep 6, 2020
  5. submodule: suppress checking for file name and ref ambiguity for object idsOrgad Shaneh via GitGitGadget, Sep 6, 2020
  6. Ramsay JonesSep 6, 2020
  7. Junio C HamanoSep 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.