Re: git gui replaces amend message when prepare-commit-msg hook is used

From: Orgad Shaneh <orgads@gmail.com>
Date: Jul 4, 2013, 10:03 UTC
Message-ID: <CAGHpTBJqVazwuNxe1m8ggcCPh9d+9Dkuv32aCqU15AZoamGwag@mail.gmail.com>
In-Reply-To: <20130704100112.GD17597@paksenarrion.iveqy.com>

On Thu, Jul 4, 2013 at 1:01 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:

Show 19 quoted lines

> On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote:
>> If a prepare-commit-msg hook is used, git gui executes it for "New Commit".
>>
>> If the "New Commit" is selected, and then immediately "Amend" (before
>> the hook returns), when the hook returns the message is replaced with
>> the one produced by the hook.
>
> I don't get it. The message from the hook is replaced with the message
> from the hook?
>
> What I don't get is how you can amend to a commit that doesn't yet
> exists. How is that possible?
>
> --
> Med vänliga hälsningar
> Fredrik Gustafsson
>
> tel: 0733-608274
> e-post: iveqy@iveqy.com

Did I say anything about a commit that doesn't exist? I have a commit which I want to amend. If I click the Amend button before the hook is done, this commit's message is replaced (in the editor, not the actual commit) with the hook's result.

The message that should appear in the editor should come from the amended commit, not from the hook.

- Orgad