Re: [PATCH] git-submodule: respect -q for add/update

From: Orgad and Raizel Shaneh <orgads@gmail.com>
Date: Sep 5, 2012, 11:42 UTC
Message-ID: <CAGHpTBJ6hWJKaQvN4oByrest_FB1fGDKa=ge4fM1HWmSWZ1tkw@mail.gmail.com>
In-Reply-To: <50461E18.6020400@web.de>

On Tue, Sep 4, 2012 at 6:28 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:

Show 19 quoted lines

>
> Am 04.09.2012 09:31, schrieb Orgad Shaneh:
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
>
> Before the "Signed-off-by" is the place where you should have
> explained why this would be a worthwhile change ;-)
>
> To me this looks like you make the default noisier and require an
> explicit "-q" to make it quiet again. There is a reason you don't
> normally get bothered with the output of the checkout command run
> under the hood of git submodule add/update, so I don't think this
> change makes things better.
>
> But you might want to think about adding a "-v/--verbose" flag to
> make the submodule add/update checkouts more verbose, in case you
> care about the output of the checkout command. That would be a
> sane thing to do, so what about changing your patch into this
> direction?
>

I don't agree the default should be quiet. That's what the (submodule) -q flag is there for.

When I run 'git submodule update' I don't expect to be in the dark until the submodule/s finishes checkout, this sometimes can take a significant amount of time and feedback is expected.

- Orgad