Re: [PATCH] reftable/stack: fsync "tables.list" during compaction

From: Justin Tobler <jltobler@gmail.com>
Date: Jan 30, 2024, 19:04 UTC
Message-ID: <CAGAWz+4wyd13UYRH3ZSSZEq1Y=5HE_p+qaXeOJS-ENMpWoLabA@mail.gmail.com>
In-Reply-To: <7bdafc9bd7f53f38a24d69a563615b6ad484e1ba.1706592127.git.ps@pks.im>

On Mon, Jan 29, 2024 at 11:23 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 11 quoted lines

>
> In 1df18a1c9a (reftable: honor core.fsync, 2024-01-23), we have added
> code to fsync both newly written reftables as well as "tables.list" to
> disk. But there are two code paths where "tables.list" is being written:
>
>   - When appending a new table due to a normal ref update.
>
>   - When compacting a range of tables during compaction.
>
> We have only addressed the former code path, but do not yet sync the new
> "tables.list" file in the latter. Fix this ommission.

nit: s/ommission/omission

>
> Note that we are not yet adding any tests. These tests will be added
> once the "reftable" backend has been upstreamed.
>

Nice catch! I noticed a small typo in the commit message but otherwise looks good to me.

-Justin