Re: [Outreachy][PATCH v2] promisor-remote: honor promisor.fetchOrder when trying remotes
- From
- Tatchou Yopa Nelly <yopatatchou@gmail.com>
- Date
- Nov 13, 2026, 19:46 UTC
- Message-ID
- <CAG7jffxyM8kQMeio1Z9Y6Wa6JsHLUuFefq5XxKKKY-tfhfjHeg@mail.gmail.com>
- In-Reply-To
- <CAP8UFD0zMp-e3Fp5SjXuHiu25718=vf+qetzwpRZmBPMJ8Vb0Q@mail.gmail.com>
Hi Christian,
Thanks for the reply, and for pointing me to the "Don't work on a proposed project right away" section I read it when I first found the project page but I misread it as only applying to projects someone else was already working on, not to the main problem of the project I was applying for. That was my mistake.
Your description of the real problem is very clear. I had not considered that the best order could depend on which remote the related objects came from, and that a single list would not be able to express that. I can see now why this needs a design discussion before any code.
I'll leave the patch as a prototype and wait for the Outreachy selections before touching it again, as Kaartic suggested.
Thanks, Yopa Nelly
On Fri, 13 Nov 2026 at 18:10, Christian Couder <christian.couder@gmail.com> wrote:
Show 25 quoted lines
> > On Fri, Nov 6, 2026 at 12:09 AM Junio C Hamano <gitster@pobox.com> wrote: > > > > Christian, I thought you are the go-to person for promisor remote, > > and if I am not mistaken, you worked on letting the server side tell > > the clients which promisors to use first? How would this mesh well > > with that? > > Sorry, for the late reply. I didn't have much time this week. > > First in https://git.github.io/General-Microproject-Information/ we > have a "Don’t work on a proposed project right away" section, but > unfortunately this patch is addressing the main issue of a project we > are proposing. > > In general I think that there should be a design doc or a long > discussion before we start implementing something, because the problem > could be complex. When you are fetching from different remotes, remote > A might want the client to get some objects from a set of promisor > remotes, like A1 and A2, while remote B, might advertise others like > B1, B2 and B3. Also after a few regular fetches from let's say A and > B, the client might need to lazy fetch some objects. Then it's not > clear which order would be best. A single order might not work well. > The best order might depend on the remote from which related objects > were fetched.