git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:03 UTC

Re: [RFC] coccinelle: detect struct strbuf passed by value

From
Deveshi Dwivedi <deveshigurgaon@gmail.com>
Date
Mar 15, 2026, 07:29 UTC
Message-ID
<CAG7UgETB7uPvWuZL08i48JvVgefJAoUqjt96C0dPNV_Qpj8jfw@mail.gmail.com>
In-Reply-To
<20260315025508.GA926820@coredump.intra.peff.net>
Show 6 quoted lines
> So the only question to me is whether people who hit the coccinelle
> suggestion might be confused by the patch output, since it doesn't carry
> any rationale. But I would rather catch the problem and risk confusion
> then have it go unnoticed.
>
> -Peff

Thanks for the review. I agree that the patch output may be a bit confusing, but it still seems useful to flag these cases. I will send a follow-up patch adding the rule and fixing the stash case.

Thanks, Deveshi

Previous: Jeff King
Message 3 of 3 in “[RFC] coccinelle: detect struct strbuf passed by value”
  1. Deveshi DwivediMar 14, 2026
  2. Jeff KingMar 15, 2026
  3. Deveshi DwivediMar 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.