Re: [PATCH v2] remote: prefetch config

From: Shubham Kanodia <shubham.kanodia10@gmail.com>
Date: Sep 5, 2024, 17:19 UTC
Message-ID: <CAG=Um+0P8SgWo2sN3St8+PpBneQfDBoqnpnC6uMmYu2YOOaWmQ@mail.gmail.com>
In-Reply-To: <xmqqy1462gc2.fsf@gitster.g>

On Thu, Sep 5, 2024 at 10:22 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>
> Shubham Kanodia <shubham.kanodia10@gmail.com> writes:
>
> >>
> >>         int prefetch; /* is prefetch enabled? */
> >>
> > ...
> > Updating my patch — please let me know if there's anything else I can
> > improve here.
>
> Renaming the .prefetch member to .prefetch_enabled would eliminate
> the need to add any comment on the member in the header file.

Do you mean for the struct member here or also the config? For the config, it'll probably be clearer to keep `prefetch` still as it aligns nicely with the boolean `--prefetch` command line flag.

I can name the struct member `prefetch_enabled` — though I don't see other boolean remote properties (`prune`, `prune_tags`) add suffixes to indicate they are booleans.

> Thanks.