Re: [PATCH] fetch: ignore wildcarded refspecs that update local symbolic refs

From: Jay Soffian <jaysoffian@gmail.com>
Date: Dec 12, 2012, 17:17 UTC
Message-ID: <CAG+J_Dw5jG4GoTuteD=w+CFG3ZbJsCB=coW9CAw=g7kz3cD2og@mail.gmail.com>
In-Reply-To: <7vmwxk6x0a.fsf_-_@alter.siamese.dyndns.org>

On Tue, Dec 11, 2012 at 5:32 PM, Junio C Hamano <gitster@pobox.com> wrote:

> In a repository cloned from somewhere else, you typically have a
> [...]
>  * This time with minimal tests and an updated log message.

Sorry I haven't been reading the list much lately, so I don't know the context which motivated this patch beyond the commit message. But, this message is quite clear. So:

Acked-by: Jay Soffian

Show 9 quoted lines

> diff --git a/remote.c b/remote.c
> index 04fd9ea..a72748c 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -1370,6 +1370,16 @@ int branch_merge_matches(struct branch *branch,
>         return refname_match(branch->merge[i]->src, refname, ref_fetch_rules);
>  }
>
> +static int ignore_symref_update(const char *refname)

s/ignore_symref_update/is_existing_symref/ ?

j.