Re: [PATCH v4 1/5] run-command: add duplicate_output_fn to run_processes_parallel_opts

From: Calvin Wan <calvinwan@google.com>
Date: Nov 30, 2022, 18:47 UTC
Message-ID: <CAFySSZDhA0kfVACcni7Gb60wNeNXm8Eg0VpC+_14Qt_HX=KFzA@mail.gmail.com>
In-Reply-To: <CABPp-BE7jNcNvF50rqJdSBr2ptwsicUwqtcjZcAV=YDKjNB-vA@mail.gmail.com>

On Mon, Nov 28, 2022 at 9:11 PM Elijah Newren <newren@gmail.com> wrote:

Show 24 quoted lines

>
> On Tue, Nov 8, 2022 at 11:11 AM Calvin Wan <calvinwan@google.com> wrote:
> >
> > Add duplicate_output_fn as an optionally set function in
> > run_process_parallel_opts. If set, output from each child process is
> > copied and passed to the callback function whenever output from the
> > child process is buffered to allow for separate parsing.
> >
> > Signed-off-by: Calvin Wan <calvinwan@google.com>
> [...]
> > diff --git a/t/helper/test-run-command.c b/t/helper/test-run-command.c
> > index 3ecb830f4a..40dd329e02 100644
> > --- a/t/helper/test-run-command.c
> > +++ b/t/helper/test-run-command.c
> > @@ -52,6 +52,21 @@ static int no_job(struct child_process *cp,
> >         return 0;
> >  }
> >
> > +static void duplicate_output(struct strbuf *process_out,
> > +                       struct strbuf *out,
> > +                       void *pp_cb,
> > +                       void *pp_task_cb)
>
> Should the last two parameters have an "UNUSED" annotation?

Yes, good catch!