Re: [RFD] Libification proposal: separate internal and external interfaces

From: Calvin Wan <calvinwan@google.com>
Date: Apr 9, 2024, 17:30 UTC
Message-ID: <CAFySSZBC6RMC3rqcMVNKUbzM_a6n5sAnKCo2rqpHmwTS4R0=GQ@mail.gmail.com>
In-Reply-To: <5663500c-ea40-45a6-bb7d-c906aee4350c@gmail.com>

On Tue, Apr 9, 2024 at 2:40 AM Phillip Wood <phillip.wood123@gmail.com> wrote:

>
> Indeed, the last set of patches allow git to be built with the same
> library that external programs can use which I thought was very welcome.
> This proposal seems to be backing away from that.

One of the questions I was grappling with was, do we want to expose all functions to external users? While it is debatable whether we would like that exposure for some of the files in libstdgit, functions in wrapper.c and usage.c seem like clear candidates for functions that have no value being exposed externally while also making it more difficult to maintain such a library in the future.