Re: [PATCH v9 2/6] submodule: rename strbuf variable

From: Calvin Wan <calvinwan@google.com>
Date: Mar 6, 2023, 17:37 UTC
Message-ID: <CAFySSZABteFiyBYp_S7bur7_K1GkxL3A5DiTiV47iU_t8EpWKQ@mail.gmail.com>
In-Reply-To: <xmqqv8jiheao.fsf@gitster.g>

On Thu, Mar 2, 2023 at 4:25 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

>
> Calvin Wan <calvinwan@google.com> writes:
>
> > A prepatory change for a future patch that moves the status parsing
> > logic to a separate function.
> >
> > Signed-off-by: Calvin Wan <calvinwan@google.com>
> > ---
> >  submodule.c | 23 +++++++++++++----------
> >  1 file changed, 13 insertions(+), 10 deletions(-)
>
> > Subject: Re: [PATCH v9 2/6] submodule: rename strbuf variable
>
> What strbuf variable renamed to what?
>
> I have a feeling that squashing this and 3/6 into a single patch,
> and pass buf.buf and buf.len to the new helper function without
> introducing an intermediate variables in the caller, would make the
> resulting code easier to follow.
>
> In any case, nice factoring out of a useful helper function.
>

A much earlier version squashed those changes together, but it was recommended to split those changes up; I think I am indifferent either way since the refactoring is clear to me whether it is split up or not. https://lore.kernel.org/git/221012.868rllo545.gmgdl@evledraar.gmail.com/