Re: [PATCH v3 1/6] run-command: add pipe_output_fn to run_processes_parallel_opts

From: Calvin Wan <calvinwan@google.com>
Date: Oct 24, 2022, 17:00 UTC
Message-ID: <CAFySSZABaWSKw_OxyPEU=C_iLOmPa=pPahWaeta=JaAf2q_GEg@mail.gmail.com>
In-Reply-To: <xmqq4jvxpw46.fsf@gitster.g>

Show 9 quoted lines

> In my review of one of the previous rounds, I asked which part of
> this functionality fits the name "pipe", and I do not think I got a
> satisfactory answer.  And after re-reading the patch in this round,
> with the in-header comments, it still is not clear to me.
>
> It looks more like sending the duplicate of the normal output to a
> side channel, somewhat like the "tee" utility, but I am not sure if
> that is the intended way to be used.
>

In this case, I was hoping "pipe" would refer to the redirection of output from the child processes to a separate custom function, but I can see that duplication != redirection. Maybe something like "parse_child_output" or "parse_output" would make sense, however, I didn't want to imply with that name that the only functionality is to parse output. Besides that, I don't really have any other ideas of what I can name it...