Re: [Outreachy PATCH] negotiator/default: stop using the_repository
- From
- Okhuomon Ajayi <okhuomonajayi54@gmail.com>
- Date
- Nov 3, 2026, 12:12 UTC
- Message-ID
- <CAFpMFfDeGJGbdCx-boKAe_Ab6oPuW-aunrdqAjtSkgqgWyhqrw@mail.gmail.com>
- In-Reply-To
- <CAP8UFD1BW7qEWp87j+7B12d=eOu80Yv1=Gf+ibEriV9s=4umag@mail.gmail.com>
On Tue, Nov 3, 2026 at 12:50 PM Christian Couder <christian.couder@gmail.com> wrote:
> As you introduced `ns`, you might use it to simplify the above line using: > > mark_common(ns, c, 0, 0);
Good point. I'll make that change in the next version.
> Many functions have their `struct repository *r` argument as their > first argument. Is there a reason why you prefered to have it as the > second argument?
No particular reason. I'll put the repository argument first in the next version.
Thanks!