git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

From
Pranit Bauva <pranit.bauva@gmail.com>
Date
Aug 21, 2016, 11:14 UTC
Message-ID
<CAFZEwPPmCyUC+mdHjYkgxhBvTwgTwyKz67T6YYJCEaBpmXyycw@mail.gmail.com>
In-Reply-To
<01020156a48144f8-c0e127c1-8cd9-4295-ac16-449a54315cac-000000@eu-west-1.amazonses.com>
Hey everyone,
On Sat, Aug 20, 2016 at 2:02 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 50 quoted lines
> `--next-all` is meant to be used as a subcommand to support multiple
> "operation mode" though the current implementation does not contain any
> other subcommand along side with `--next-all` but further commits will
> include some more subcommands.
>
> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Mentored-by: Lars Schneider <larsxschneider@gmail.com>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---
>  builtin/bisect--helper.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 3324229..8111c91 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -10,11 +10,11 @@ static const char * const git_bisect_helper_usage[] = {
>
>  int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>  {
> -       int next_all = 0;
> +       enum { NEXT_ALL = 1 } cmdmode = 0;
>         int no_checkout = 0;
>         struct option options[] = {
> -               OPT_BOOL(0, "next-all", &next_all,
> -                        N_("perform 'git bisect next'")),
> +               OPT_CMDMODE(0, "next-all", &cmdmode,
> +                        N_("perform 'git bisect next'"), NEXT_ALL),
>                 OPT_BOOL(0, "no-checkout", &no_checkout,
>                          N_("update BISECT_HEAD instead of checking out the current commit")),
>                 OPT_END()
> @@ -23,9 +23,14 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>         argc = parse_options(argc, argv, prefix, options,
>                              git_bisect_helper_usage, 0);
>
> -       if (!next_all)
> +       if (!cmdmode)
>                 usage_with_options(git_bisect_helper_usage, options);
>
> -       /* next-all */
> -       return bisect_next_all(prefix, no_checkout);
> +       switch (cmdmode) {
> +       case NEXT_ALL:
> +               return bisect_next_all(prefix, no_checkout);
> +       default:
> +               die("BUG: unknown subcommand '%d'", cmdmode);
> +       }
> +       return 0;
>  }
This is the same series (except for patch 04/13) and rebased on v2.10-rc0.

Regards, Pranit Bauva

Previous: Pranit Bauva
Message 15 of 15 in “bisect--helper: use OPT_CMDMODE instead of OPT_BOOL”
  1. 01/13 bisect--helper: use OPT_CMDMODE instead of OPT_BOOLPranit Bauva, Aug 19, 2016
  2. 02/13 bisect: rewrite `check_term_format` shell function in CPranit Bauva, Aug 19, 2016
  3. 13/13 bisect--helper: `bisect_start` shell function partially in CPranit Bauva, Aug 19, 2016
  4. 07/13 bisect--helper: `bisect_reset` shell function in CPranit Bauva, Aug 19, 2016
  5. 11/13 bisect--helper: `bisect_next_check` & bisect_voc shell function in CPranit Bauva, Aug 19, 2016
  6. 12/13 bisect--helper: `get_terms` & `bisect_terms` shell function in CPranit Bauva, Aug 19, 2016
  7. 09/13 bisect--helper: `bisect_write` shell function in CPranit Bauva, Aug 19, 2016
  8. 08/13 bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in CPranit Bauva, Aug 19, 2016
  9. 03/13 bisect--helper: `write_terms` shell function in CPranit Bauva, Aug 19, 2016
  10. 06/13 wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()Pranit Bauva, Aug 19, 2016
  11. 04/13 bisect--helper: `bisect_clean_state` shell function in CPranit Bauva, Aug 19, 2016
  12. Pranit BauvaAug 21, 2016
  13. 10/13 bisect--helper: `check_and_set_terms` shell function in CPranit Bauva, Aug 19, 2016
  14. 05/13 t6030: explicitly test for bisection cleanupPranit Bauva, Aug 19, 2016
  15. Pranit BauvaAug 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.