Re: [PATCH v2] builtin/commit.c: memoize git-path for COMMIT_EDITMSG

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Jun 9, 2016, 09:54 UTC
Message-ID: <CAFZEwPPRirGKqA4=qY+TrSmkGomZVZjLqOG-ZKwciK8hLhhdHg@mail.gmail.com>
In-Reply-To: <20160609065805.GA19015@sigill.intra.peff.net>

Hey Jeff,

On Thu, Jun 9, 2016 at 12:28 PM, Jeff King <peff@peff.net> wrote:

Show 21 quoted lines

> On Tue, Jun 07, 2016 at 08:25:17PM +0530, Pranit Bauva wrote:
>
>> On Wed, May 25, 2016 at 12:49 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> > This is a follow up commit for f932729c (memoize common git-path
>> > "constant" files, 10-Aug-2015).
>> >
>> > The many function calls to git_path() are replaced by
>> > git_path_commit_editmsg() and which thus eliminates the need to repeatedly
>> > compute the location of "COMMIT_EDITMSG".
>> >
>> > Mentored-by: Lars Schneider <larsxschneider@gmail.com>
>> > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
>> > Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
>> > ---
>> [...]
>> Anyone any comments?
>
> Looks good to me. You may want to re-post without the quoting to make it
> easier for the maintainer to pick up, and feel free to add my:
>
>   Reviewed-by: Jeff King <peff@peff.net>

Sure I could re-post it. Thanks for your tag! :)

Regards, Pranit Bauva