git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: clarify signature verification v2

From
Pranit Bauva <pranit.bauva@gmail.com>
Date
May 12, 2016, 17:32 UTC
Message-ID
<CAFZEwPOgQcyuVjrWsxgz+vTe+0qEbBPo3YSdKpGc0Zb6YB7tAw@mail.gmail.com>
In-Reply-To
<xmqq4ma3grj0.fsf@gitster.mtv.corp.google.com>
On Thu, May 12, 2016 at 10:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> Pranit Bauva <pranit.bauva@gmail.com> writes:
>
>> Seems like Junio was waiting for someone to point this out[2].
>
> Thanks. I think you covered most of them correctly; I only have one
> thing to add.
>
>>  * Comments are put after ---. So your paragraph
>>       "Clarify which commits need to be signed.
>>
>>         Uniformise the vocabulary used wrt. key/signature validity with OpenPGP
>>          - a signature is valid if made by a key with a valid uid;
>>          - in the default trust-model, a uid is valid if signed by a
>> trusted key;
>>          - a key is trusted if the (local) user set a trust level for it.
>>
>>            Thanks to Junio C Hamano <gitster@pobox.com> for reviewing
>>            the first attempt at this patch."
>>
>>     is actually treated as a comment.
>
> This is half-true, I think. The message you are responding to had
> only two dashes, not three.
My bad. Didn't carefully notice it.
Show 27 quoted lines
>
> The usual way to do what the original wanted to do is like this:
>
>         ... e-mail headers like From:, Subject:, ...
>
>         Hi,
>
>         Here is a second attempt.
>
>         -- >8 --
>         Subject: Documentation: clarify --verify signature
>
>         Clarify that only the signature of the commit at the tip of
>         the branch being merged is checked.  Also align the
>         vocabulary to describe key & signature validity with those
>         used by OpenPGP, namely:
>
>          - a signature is valid if ...
>          ...
>          - a key is trusted if ...
>
>         Signed-off-by: A U Thor <au@thor.xz>
>         ---
>          Documentation/merge-options.txt | ... diffstat comes here
>
> Notice the "-- >8 --" (cut here) line.  "am" will notice it, discard
> what it has read so far and restart from there.

Not having used this personally, I forgot to mention this. Thanks for mentioning it! Looks like you have written the commit message for him. :)

Previous: Junio C HamanoNext: KellerFuchs
Message 5 of 6 in “Documentation: clarify signature verification v2”
  1. Documentation: clarify signature verification v2Fox in the shell, May 12, 2016
  2. Pranit BauvaMay 12, 2016
  3. Pranit BauvaMay 12, 2016
  4. Junio C HamanoMay 12, 2016
  5. Pranit BauvaMay 12, 2016
  6. KellerFuchsMay 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.