git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/GSoC 3/3] Nousage message in error

From
Pranit Bauva <pranit.bauva@gmail.com>
Date
Mar 24, 2016, 16:28 UTC
Message-ID
<CAFZEwPOd2RyfF5eMqB5XZqNg5Oc_fbDmERcOAMpgR81pmPOPQg@mail.gmail.com>
In-Reply-To
<xmqqh9fvalpm.fsf@gitster.mtv.corp.google.com>
On Thu, Mar 24, 2016 at 9:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> Pranit Bauva <pranit.bauva@gmail.com> writes:
>
>> A general convention followed by git users it to write the commit
>> message as "What he did to the code?" rather than "What problem was
>> there in the code?"
>
> It is OK for other projects to adopt a different convention, but The
> project convention here is different.
>
> We tend to write our log message like this in this order:
>
>  - Explain relevant behaviour and code structure in the current code
>    to refresh memory of readers to help them understand the next two
>    items better.  This paragraph is optional and you see it only in
>    difficult patches.
>
>  - Desribe the problem.  What the end user would do and what she
>    sees in response to it, why that is not a good outcome, and what
>    would be a better outcome.  For a patch to only improve code,
>    replace "the end user" with "other codepaths that interact with
>    the code being changed".
>
>  - Explain the approach to implement a better outcome.  This
>    paragraph is optional and you see it only in patches that
>    implement tricky solutions.
>
>  - Describe the solution, as if you are giving orders to the
>    maintainers to change the code this way and that way.

Thanks for making it clearer to me! I tend to write bad commit messages. Improving on it though.

Previous: Junio C HamanoNext: Pranit Bauva
Message 4 of 5 in “Nousage message in error”
  1. 3/3 Nousage message in errorDiwas Joshi, Mar 24, 2016
  2. Pranit BauvaMar 24, 2016
  3. Junio C HamanoMar 24, 2016
  4. Pranit BauvaMar 24, 2016
  5. Pranit BauvaMar 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.