Re: [PATCH v9 3/3] commit: add a commit.verbose config variable
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Mar 24, 2016, 10:26 UTC
- Message-ID
- <CAFZEwPNyELB2BZ1q95HroV0a3vfNK0eTtzcy-2aEmUY5QVZe-g@mail.gmail.com>
- In-Reply-To
- <CAFZEwPN2+RwrE583XHOv9=05XQaWZnL=cK6wa0rMC-3AU275yg@mail.gmail.com>
I got it. The verbose is initialised to -1 before. When cmd_commit runs, it changes the value of verbose accordingly to 0 or positive. But when cmd_status runs, it will retain the value -1 and the if clause which accepts all values except 0 will execute. I guess a if statement inside cmd_status which reinitialises it to 0 or positive depending on the situation will solve the problem.
On Thu, Mar 24, 2016 at 3:52 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 41 quoted lines
> On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor <szeder@ira.uka.de> wrote: >>> Add commit.verbose configuration variable as a convenience for those >>> who always prefer --verbose. >>> >>> Helped-by: Junio C Hamano <gitster@pobox.com> >>> Helped-by: Eric Sunshine <sunshine@sunshineco.com> >>> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> >>> >>> --- >>> The previous version of the patch are: >>> - [v8] $gmane/288820 >>> - [v7] $gmane/288820 >>> - [v6] $gmane/288728 >>> - [v5] $gmane/288728 >>> - [v4] $gmane/288652 >>> - [v3] $gmane/288634 >>> - [v2] $gmane/288569 >>> - [v1] $gmane/287540 >>> >>> Changes with respect to the previous patch: >>> - Compare with -1 as only -1 value is used for unspecified behavior. >>> - Write clean tests >>> --- >>> Documentation/config.txt | 4 ++++ >>> Documentation/git-commit.txt | 3 ++- >>> builtin/commit.c | 13 ++++++++++- >>> t/t7507-commit-verbose.sh | 51 ++++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 69 insertions(+), 2 deletions(-) >> >> Please always run the full test suite before submitting patches to >> make sure that your changes do not inadvertently break something. >> This patch breaks several tests in t7512-status-help.sh, >> t7508-status.sh and t7060-wtstatus.sh. > > Sorry for that. I will make sure I do run the complete test suite. I > currently ran only commit based tests. But now that I think about it > that since status and commit share a lot of things, it might be > possible to break parts of status. I will investigate further as to > what cased this problem though I kind of get a hint that it is because > of verbose being the parent and others consuming it. There are a lot > of tests failing.