Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: May 20, 2016, 07:23 UTC
Message-ID: <CAFZEwPMFBmHUaX+Y8Fpd4BnJiB8N_XBOX30hRsSvb3tm8-MX5w@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1605160838540.3303@virtualbox>

Hey Johannes,

On Mon, May 16, 2016 at 12:10 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 11 quoted lines

> Hi Pranit,
>
> On Sat, 14 May 2016, Pranit Bauva wrote:
>
>> Reimplement the `bisect_voc` shell function in C. This is a too small
>> function to be called as a subcommand though the working of this
>> function has been tested by calling it as a subcommand.
>
> This leaves me puzzled as to what this patch is supposed to do. Maybe
> rename this function to have a more intuitive name, and then throw in a
> patch that makes use of the function?

Are you suggesting to first have an introductory patch which will rename the function in the shell script and then this patch which will convert the "new" shell function to C? I can do this. I have to think of a nice name. How does 'good_or_bad" sound?

Regards, Pranit Bauva