git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Tolerate zlib deflation with window size < 32Kb

From
Roberto Tyley <roberto.tyley@gmail.com>
Date
Aug 4, 2011, 07:40 UTC
Message-ID
<CAFY1edZLAjVRs0LUx6CvD9i5aZu6kZ1ecJdUsvZgmtGkajOqow@mail.gmail.com>
In-Reply-To
<CAFY1edZyO7oYDi+tV2mxbhBHY_cf2F0bD7+KF9rxmKYygSFAjA@mail.gmail.com>
On 4 August 2011 00:56, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> roberto.tyley@gmail.com writes:
> > -     if (map[0] == 0x78 && !(word % 31))
> > +     if ((map[0] & 0x88) == 0x08 && !(word % 31))
>
> Are you sure about this 0x88? Isn't it 0x8F or something?

Ah- yes, you're right - the bitmask should be 0x8F, because the lower nibble of a deflated zlib stream is 8 (8=deflate) and we want to match all 4 bits.

Thankfully the rest of the logic still applies - I'll submit an updated patch in a minute, once I've conquered my embarrassment :-)

Previous: Junio C HamanoNext: Sverre Rabbelier
Message 3 of 8 in “Tolerate zlib deflation with window size < 32Kb”
  1. Tolerate zlib deflation with window size < 32Kbroberto.tyley@gmail.com, Aug 3, 2011
  2. Junio C HamanoAug 3, 2011
  3. Roberto TyleyAug 4, 2011
  4. Sverre RabbelierAug 4, 2011
  5. Junio C HamanoAug 4, 2011
  6. Tolerate zlib deflation with window size < 32Kbroberto.tyley@gmail.com, Aug 7, 2011
  7. Junio C HamanoAug 8, 2011
  8. Junio C HamanoAug 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.