Re: [gitgitgadget/git] Reftable support git-core (#539)
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Apr 22, 2020, 15:18 UTC
- Message-ID
- <CAFQ2z_MCG3pD3i3nAJcvQEKytQdHBO8X9ssmeM=pbypghEvwzQ@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2004221327020.46@tvgsbejvaqbjf.bet>
x
On Wed, Apr 22, 2020 at 1:27 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 10 quoted lines
> > > > Here is the message: <nycvar.QRO.7.76.6.2004101604210.46@tvgsbejvaqbjf.bet> > > > > > > > > Thanks for the reference. I'll look into it. > > > > Johannes, if you have specific comments about the reftable patch, please > > include me (hanwen@google.com) explicitly on your messages. > > Sorry, I forgot. Will try to do better next time.
I fixed all the outstanding issues in the last push to GGG. For the record, the following caused segfaults:
https://github.com/google/reftable/commit/31078a87067ec9c33f496afb6b478eed6e9c3d12 https://github.com/google/reftable/commit/9107ddd6ed73844cb9092dc18ba92091a1132a9e
The message about "bad replace ref name" was a missing copy of the prefix filter.
The C reftable library was based on the code I wrote in Go first, and I keep both versions in sync, hence the null/zero initialization of data throughout.
By now I'm an expert on reftable, but not so much about Git's test infrastructure, and unfortunately, I lack the time to become an expert without your guidance, so please give specific feedback.
The most pressing thing right now is that the windows port on GGG says
++ git tag file fatal: reftable: transaction failure general error
which suggests that renames don't work like I think they do on windows.
> Ciao, > Dscho
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado