Re: [PATCH v6? 00/17] refs API: get rid of errno setting entirely

From: Han-Wen Nienhuys <hanwen@google.com>
Date: Jul 13, 2021, 08:28 UTC
Message-ID: <CAFQ2z_M7FzR6HEea2Xj-j=LiTsjQvpGJc+h+D+GgU=ZEkWm50A@mail.gmail.com>
In-Reply-To: <cover-00.17-00000000000-20210711T162803Z-avarab@gmail.com>

On Sun, Jul 11, 2021 at 6:30 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

>
> After starting a review of v5 of Han-Wen's where I was coming up with
> squashes-on-top I continued with it and saw if I could get rid of
> errno setting entirely in refs.

thanks for taking this further! Is there a place where I can pull this code (applying patches is bothersome).

It adds resolve_refs_unsafe_with_errno() to the public API in refs.h, and I think it has an ugly signature, but I suppose it's better than having the output be implicit through the global errno variable.

I read over your patches, and they seem OK to me, modulo small comments I posted.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado