git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH] doc: fix typo in tree-walk.h comment

From
AJAyush Jha <kumarayushjha123@gmail.com>
Date
Feb 16, 2026, 07:54 UTC
Message-ID
<CAFNBzOfy6Gcx=jcDDBGzwELskTAAjKbNiDNGwh=QNLz8T+-O2g@mail.gmail.com>
In-Reply-To
<CA+J6zkRtjxa2BUoa9SMXVET7w4O6=b8iYMLPPpb4REROPGGQNA@mail.gmail.com>
Hi Chandra,

Thank you for pointing that out. You’re absolutely right — the subject line should use “tree-walk.h:” instead of “doc:” since the change is in the header file and not in Documentation.

Would you prefer that I resend the patch with the corrected subject prefix?
Thanks again for the review and guidance.

Best regards, Ayush

On Fri, Feb 6, 2026 at 10:27 PM Chandra Pratap <chandrapratap3519@gmail.com> wrote:

Show 36 quoted lines
>
> On Thu, 5 Feb 2026 at 13:39, Ayush Jha <kumarayushjha123@gmail.com> wrote:
> >
> > Fix a duplicated word in a comment describing the return value.
> >
> > No code or behavior change.
> >
> > Signed-off-by: Ayush Jha <kumarayushjha123@gmail.com>
> > ---
> >  tree-walk.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tree-walk.h b/tree-walk.h
> > index 29a55328bd..9646c47ac5 100644
> > --- a/tree-walk.h
> > +++ b/tree-walk.h
> > @@ -177,7 +177,7 @@ struct traverse_info {
> >
> >  /**
> >   * Walk trees starting with "tree_oid" to find the entry for "name", and
> > - * return the the object name and the mode of the found entry via the
> > + * return the object name and the mode of the found entry via the
> >   * "oid" and "mode" parameters.  Return 0 if the entry is found, and -1
> >   * otherwise.
> >   */
> > --
> > 2.53.0.windows.1
>
> Nit: The subject line should preferably use 'tree-walk.h: ' instead of 'doc: '
> since it is a change to the `tree-walk.h` file and not 'Documentation'.
>
> Other than that, the change looks good to me. Thanks for your interest
> in contributing to Git!
>
> Thanks,
> Chandra.
Previous: Chandra Pratap
Message 3 of 3 in “doc: fix typo in tree-walk.h comment”
  1. doc: fix typo in tree-walk.h commentAyush Jha, Feb 5, 2026
  2. Chandra PratapFeb 6, 2026
  3. Ayush JhaFeb 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.