Re: [PATCH] Fix compilation on OS X.

From: tsuna <tsunanet@gmail.com>
Date: Jul 20, 2013, 07:56 UTC
Message-ID: <CAFKYj4fdYHKukM7kaxxTKYNqTfOXadmZynTxXO9824G6H6HiZA@mail.gmail.com>
In-Reply-To: <CALkWK0m46SR3C6R_pjYouu7LkHjL_gPGb1A3S94d0nx8227-UA@mail.gmail.com>

On Sat, Jul 20, 2013 at 12:55 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 16 quoted lines

> Benoit Sigoure wrote:
>> diff --git a/compat/unsetenv.c b/compat/unsetenv.c
>> index 4ea1856..addf3dc 100644
>> --- a/compat/unsetenv.c
>> +++ b/compat/unsetenv.c
>> @@ -1,5 +1,10 @@
>>  #include "../git-compat-util.h"
>>
>> +#ifdef __APPLE__
>> +// On OS X libc headers don't define this symbol.
>> +extern char **environ;
>> +#endif
>> +
>
> Shouldn't this go into git-compat-util.h, since there may be other
> files depending on this variable?

I thought about that but there are no other files that use `environ' so I opted for putting it here instead.

-- 
Benoit "tsuna" Sigoure