Re: [PATCH] Undefine strlcpy if needed.

From: tsuna <tsunanet@gmail.com>
Date: Aug 25, 2014, 01:54 UTC
Message-ID: <CAFKYj4cDJhiVfdmzZ5KnNASBEp9bkj0asxANPv43QcMQP06z9A@mail.gmail.com>
In-Reply-To: <53FA8438.5070107@ramsay1.demon.co.uk>

On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

> Again, I don't have access to an OS X system, so I don't know
> which package provides libintl/gettext, but it seems to be missing
> on your system.

Probably yeah, those libraries don’t seem to be provided in standard with OS X or OS X’s development tools, so maybe the Makefile should also default to having NO_GETTEXT=YesPlease when on OS X.

Show 15 quoted lines

> You can avoid the build failure, without running configure, by
> setting NO_GETTEXT=YesPlease in your config.mak file.
>
>>
>>
>> I need to run configure first:
>>
>> $ make configure
>>     GEN configure
>> $ ./configure
>> configure: Setting lib to 'lib' (the default)
>> […]
>
> So, presumably, configure has set NO_GETEXT=YesPlease in your
> config.mak.autogen file.

Yes it did.

I don’t mind running configure, but so far Git has compiled fine without doing it. Should we fix the default values of NO_STRLCPY / NO_GETEXT on OS X?

-- 
Benoit "tsuna" Sigoure