Re: [PATCH v3 2/2] userdiff: extend Scheme support to cover other Lisp dialects
- From
Scott L. Burson <scott@sympoiesis.com>
- Date
- Jan 17, 2026, 02:09 UTC
- Message-ID
- <CAF5LJ4Du-x9ND-EHCe0Npz9GaE7kinEYNnpP_416cKpZuxc9hg@mail.gmail.com>
- In-Reply-To
- <3243b63b-b0c1-42d5-beeb-df42b891f09e@kdbg.org>
On Fri, Jan 16, 2026 at 12:49 AM Johannes Sixt <j6t@kdbg.org> wrote:
> > The commit message doesn't mention the changes regarding the word-diff > pattern. I would have prefered to have them in their own patch; it > would make the patch text less obscure about what it actually changes.
Okay, will do.
Show 17 quoted lines
> > diff --git a/Documentation/gitattributes.adoc b/Documentation/gitattributes.adoc > > index f20041a323..a9ce5adef9 100644 > > --- a/Documentation/gitattributes.adoc > > +++ b/Documentation/gitattributes.adoc > > @@ -912,6 +912,7 @@ patterns are available: > > > > - `scheme` suitable for source code in the Scheme language. > > +Also handles Emacs Lisp, Common Lisp, and most other dialects. > > Saying "most dialects" immediately begs the questions "which dialects > are not covered" and "is the dialect that I'm using covered". Let's > write it this way: > > - `scheme` suitable for source code in the Lisp dialects including > Scheme, Emacs Lisp, Common Lisp. > > Note the indentation of the continuation line
Of course I will fix the indentation, but I don't agree with your proposal for the text. There are many Lisp dialects in use, indeed probably thousands; lots of people write their own. As previously noted, matching an unindented open parenthesis is a very general heuristic that is likely to work for the vast majority of dialects. While we can't answer the question "is the dialect I'm using covered?" for everyone, I think the text should encourage them to give the driver a try.
So how about this:
- `scheme` suitable for source code in most Lisp dialects, including Scheme, Emacs Lisp, Common Lisp, and Clojure.
I've looked at some Clojure and I believe the proposed regexp will work for it. I think it's a good idea to mention it explicitly, because people might search the text for it.
> Using the identifier "|the \| greeting|" could make the test even more > complete, I think.
Agreed, will do.
-- Scott