Re: [PATCH v2 0/5] worktree repair: avoid breaking unrelated .git file and gitdir
- From
Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
- Date
- Oct 15, 2026, 13:41 UTC
- Message-ID
- <CAF5D8-uzTe2qm8MdoADkSunrKhc_qSLzjBG9CGR5tDAS32Xh5A@mail.gmail.com>
- In-Reply-To
- <xmqqmrsfq4rm.fsf@gitster.g>
Sorry, I sent the previous email in HTML. I'm resending it as plain text.
On Thu, Oct 15, 2026 at 7:46 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> > "Yoichi NAKAYAMA via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > 'git worktree repair' does not sufficiently validate the cross-references > > between a linked working tree and its administrative data before repairing > > them. This can cause the repair to modify the wrong .git file or gitdir in > > certain situations. > > > > > > v2 (0156021) > > ============ > > > > Split the first commit of v1 to make the changes easier to understand. Fold > > long lines. > > > > * [1/5] align .git file handling with repair_gitfile() > > * [2/5] centralize inferred backlink selection > > * [3/5] use read_gitfile_raw() in infer_backlink() > > * [4/5] reduce .git file reads > > * [5/5] avoid breaking unrelated .git file and gitdir > > Makes more sense to have this series as a logical progression of > smaller pieces compared to v1. > > What is "0156021" by the way?
It is the first 7 characters of the commit hash in https://github.com/gitgitgadget/git/ (Creating a commit from an email changes the commit hash, so the identifier was meaningless.)
Thanks, -- Yoichi NAKAYAMA