Test failures with python versions when building git 1.8.1

From: Dan McGee <dan@archlinux.org>
Date: Jan 2, 2013, 04:12 UTC
Message-ID: <CAEik5nOqge8ix4WGf-h+0Dmz1CanH_XtQdB-CxvPsggSu1-LzQ@mail.gmail.com>

A test case snuck in this release that assumes /usr/bin/python is python2 and causes test failures. Unlike all other tests and code depending on python, this one does not respect PYTHON_PATH, which we explicitly set when building git on Arch Linux due to python2 vs python3 differences.

-Dan

make[1]: Entering directory `/build/src/git-1.8.1/t' rm -f -r test-results *** prove ***

Test Summary Report
-------------------
t9020-remote-svn.sh                              (Wstat: 256 Tests: 6 Failed: 4)
  Failed tests:  1-2, 5-6
  Non-zero exit status: 1
Files=608, Tests=8772, 76 wallclock secs ( 4.07 usr  0.65 sys + 91.83
cusr 37.14 csys = 133.69 CPU)
Result: FAIL
make[1]: *** [prove] Error 1
make[1]: Leaving directory `/build/src/git-1.8.1/t'
make: *** [test] Error 2

$ contrib/svn-fe/svnrdump_sim.py
  File "contrib/svn-fe/svnrdump_sim.py", line 43
    print "usage: %s dump URL -rLOWER:UPPER"
                                           ^
SyntaxError: invalid syntax

diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe/svnrdump_sim.py
index 1cfac4a..7e6148d 100755
--- a/contrib/svn-fe/svnrdump_sim.py
+++ b/contrib/svn-fe/svnrdump_sim.py
@@ -40,7 +40,7 @@ def writedump(url, lower, upper):

 if __name__ == "__main__":
         if not (len(sys.argv) in (3, 4, 5)):
-                print "usage: %s dump URL -rLOWER:UPPER"
+                print("usage: %s dump URL -rLOWER:UPPER")
                 sys.exit(1)
         if not sys.argv[1] == 'dump': raise NotImplementedError('only
"dump" is suppported.')
         url = sys.argv[2]