git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-tree: don't append a newline with -F

From
Ross Kabus <rkabus@aerotech.com>
Date
Sep 8, 2017, 22:06 UTC
Message-ID
<CAEVs+zYrKxX0S9LMoBLB3vqG5n3PuMGMCehipbpCmFA7dW95qw@mail.gmail.com>
In-Reply-To
<xmqqa8260y7g.fsf@gitster.mtv.corp.google.com>
On Thu, Sep 7, 2017 at 9:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
>     commit-tree: do not complete line in -F input
>
>     "git commit-tree -F <file>", unlike "cat <file> | git
>     commit-tree" (i.e. feeding the same contents from the standard
>     input), added a missing final newline when the input ended in an
>     incomplete line.
>
>     Correct this inconsistency by leaving the incomplete line as-is,
>     as erring on the side of not touching the input is preferrable
>     and expected for a plumbing command like "commit-tree".

That all makes sense to me and is clearer too, I like this change. Do I need to resubmit the patch or will you just use that text instead?

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “commit-tree: don't append a newline with -F”
  1. commit-tree: don't append a newline with -FRoss Kabus, Sep 7, 2017
  2. Junio C HamanoSep 8, 2017
  3. Ross KabusSep 8, 2017
  4. Junio C HamanoSep 9, 2017
  5. commit-tree: do not complete line in -F inputRoss Kabus, Sep 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.