Re: [PATCH v2 2/2] git-cvsimport: allow local timezone for commits

From: Christopher Rorvick <chris@rorvick.com>
Date: Oct 14, 2012, 20:58 UTC
Message-ID: <CAEUsAPYbywPJUje8LGsOMYn_oQ-RFxznjZ1KeAsZL=skiDtG3g@mail.gmail.com>
In-Reply-To: <7vfw5hzj16.fsf@alter.siamese.dyndns.org>

On Sun, Oct 14, 2012 at 1:04 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Chris Rorvick <chris@rorvick.com> writes:
>
>> CVS patches are imported with the timezone offset of +0000 (UTC).
>> Allow timezone offsets to be calculated from the the local timezone by
>> adding -l to the command line or specifying cvsimport.l in the config.
>
> A single "I do not like everybody's timestamp is in GMT, so instead
> use the local timezone I the importer happen to be in" sounds more
> like an uninteresting hack with limited application than a useful
> new feature.  Even back in CVS days, many projects and repositories
> worth converting to Git were multi-people projects that span across
> timezones.
>
> I am wondering if it is sufficient to enhance existing cvs-authors
> file to tie a person to a timezone to add a feature like this in a
> more sensible manner.  I'd assume that in many multi-person project,
> one person, even when travelling, tend to record commits in a single
> timezone (i.e. his or her home timezone).  Even for a single-person
> project, adding a single entry ot the file is not too much to ask to
> the user.  Being able to view his human-readable name and timezone
> would be good value for the amount of trouble.

This sounds pretty straight forward. It had crossed my mind that using the cvs-authors file like this would be a more general solution, but I thought that what I proposed was at least a step in the right direction. But since anyone that cares about this is almost certainly putting together a cvs-authors file anyway, I agree that being able to set an alternate default timezone probably isn't a very useful addition.

I'll resubmit when I have something working.