Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions

From: Benoit Person <benoit.person@gmail.com>
Date: Sep 24, 2013, 08:05 UTC
Message-ID: <CAETqRCjo3_nr0+Jh_0XTPZysfzhtGaeFMGswog--Era31jQo1Q@mail.gmail.com>
In-Reply-To: <CAPig+cSVeJX2wHo7TTJe2oa+_pD7EPdmMo_BGO_Bj-ZKgRD6wA@mail.gmail.com>

On 23 September 2013 19:58, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

> I'd rather have the comments say "# API version < X" and "# API version
>>= X". Next time the API change, "new" Vs "old" will become meaningless.

done, thanks

On 23 September 2013 20:26, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 8 quoted lines

> Some distros (e.g., Debian) occasionally do run the testsuite
> automatically, but it is still fine since they have a timeout that
> varies by platform to detect if the test has stalled.  I suppose
> ideally git's test harness could learn to do the same thing some day,
> but for now it's easier one level above since an appropriate timeout
> depends on the speed on the platform, what else is creating load on
> the test machine, and other factors that are probably not easy for us
> to guess.

great explanation, thanks

On 23 September 2013 22:17, Eric Sunshine <sunshine@sunshineco.com> wrote:

> s/seq/test_seq/

done, thanks

Show 6 quoted lines

> d17cf5f3a32f07bf (tests: Introduce test_seq;  2012-08-03)
>
>> +       do
>> +               echo "creating revision $i"
>
> Do you want to end this line with '&&'?

The way it's intended is that it's more a debug information to see how it's going on (creating >500 revs is *quite* long). If I understand it correctly, using '&&' would mean that the return value of the echo statement will be tested for success ? Anyway, I am not sure it makes sense to fail on a "debug echo" ?

-- 
Benoit Person