Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

From: Benoît Person <benoit.person@ensimag.fr>
Date: Jun 18, 2013, 09:06 UTC
Message-ID: <CAETqRCjiMh_cYuZit5Z8OLki_RTz8=ViYPMv005iQu9Fv=U0ow@mail.gmail.com>
In-Reply-To: <vpq8v299pn6.fsf@anie.imag.fr>

On 17 June 2013 09:12, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 12 quoted lines

>>> Also, it seems to be only part of the solution. With your change, from
>>> contrib/mw-to-git/ and after running only "make",
>>>
>>> ./git-mw takes the installed version of GitMediawiki.pm in priority
>>>
>>> ../../bin-wrappers/git takes the installed version of git-mw only (i.e.
>>> does not know "git mw" if "make install" hasn't been ran).
>> Same thing as the documentation point, I think I am a bit lost in that
>> whole thing. I will re-look into it for the next version :/ .
>
> In short, the include path should contain both the *.pm file and the
> git-<foo> ones.

The fact is, for now, is there a way to test changes in git-remote-mediawiki.perl without 'make install'-ing it ? I could not find one

So maybe in the "build-perl-script" of the toplevel Makefile we could add something copying the script at the toplevel ?

And in GitMediawiki's Makefile, we let everything stay as is : copying *.pm into /perl/blib/lib when building and copying it in installdir when installing ?

Show 5 quoted lines

> I think you removed a newline from the end of the file. It's usually
> considered good practice to have this trailing newline (e.g. so that
> "cat file" in a terminal doesn't put your prompt after the last line).
> IIRC, it's actually required to call the file a "text file" according to
> POSIX.

That catch oO, thanks for the explanations. From my point of view, this could definitely be improved from:

> -     perlcritic -2 *.perl
> +     perlcritic -2 *.perl
> \ No newline at end of file

to something like that:

> -     perlcritic -2 *.perl
> +     perlcritic -2 *.perl
> \ removed newline at end of file

which gives more insights into why the line is considered "edited".

Benoit Person