Re: [PATCH v2] commit-tree: utilize parse-options api

From: Brandon Richardson <brandon1024.br@gmail.com>
Date: Mar 2, 2019, 03:35 UTC
Message-ID: <CAETBDP5vU7DAAT+qgr8bBukYy2YxABPXO0WTrr+gEfdw1_4mEg@mail.gmail.com>
In-Reply-To: <CAPig+cQoZQCTAzaDiaAdAvSqHBHSoapDoVLjPtpKjCEVSBL57g@mail.gmail.com>

Hi Eric,

On Fri, Mar 1, 2019 at 3:53 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> Note, in particular how Peff used !(arg) rather than (!arg) in your
> patch. This distinction is subtle but important enough to warrant
> being called out. The reason that Peff did it this way (the _correct_
> way) is that, as a macro argument, 'arg' may be a complex expression
> rather than a simple boolean. for instance, a caller could conceivably
> invoke the macro as:
>
>     BUG_ON_OPT_NOARG(unset, foo || bar)

Thanks for pointing this out. I caught this shortly after I submitted v2. I hadn't considered that the argument could be an expression. Will fix in v3.